Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AllVars fix for CMIP6's ICON-ESM-LR #1582

Merged
merged 1 commit into from
May 13, 2022
Merged

Added AllVars fix for CMIP6's ICON-ESM-LR #1582

merged 1 commit into from
May 13, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented May 13, 2022

Description

The CMIP6 model ICON-ESM-LR has wrong var_names for latitude and longitude. This PR adds a fix for this.

Note: This is not related to the ICON native model CMORizer!

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label May 13, 2022
@schlunma schlunma added this to the v2.6.0 milestone May 13, 2022
@schlunma schlunma requested a review from valeriupredoi May 13, 2022 10:50
@schlunma schlunma self-assigned this May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1582 (4e6afef) into main (8af46d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   90.81%   90.82%           
=======================================
  Files         199      200    +1     
  Lines       10628    10637    +9     
=======================================
+ Hits         9652     9661    +9     
  Misses        976      976           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip6/icon_esm_lr.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af46d4...4e6afef. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, cheers, Manu! 🍺

@schlunma
Copy link
Contributor Author

Thanks! 🚀

@schlunma schlunma merged commit 9c5681f into main May 13, 2022
@schlunma schlunma deleted the fix_icon branch May 13, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants