Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all results on recipe results webpage #1560

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Apr 15, 2022

Description

Closes #1535


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the bug Something isn't working label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1560 (0d64275) into main (b09dde2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1560   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         197      197           
  Lines       10572    10574    +2     
=======================================
+ Hits         9596     9598    +2     
  Misses        976      976           
Impacted Files Coverage Δ
esmvalcore/_recipe.py 95.83% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09dde2...0d64275. Read the comment docs.

@bouweandela bouweandela marked this pull request as ready for review April 15, 2022 16:45
@bouweandela bouweandela requested a review from schlunma April 15, 2022 16:48
@bouweandela bouweandela added this to the v2.6.0 milestone Apr 15, 2022
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe, that looks great!

I tested this with both remove_preproc_dir=True and remove_preproc_dir=False and got the excepted results in both cases.

One comment: This now includes all preprocessed files in the html file (see image below). Thus, the list of output files can be very long for recipes that use lots of input data. I personally think this is fine, especially since it can be disabled with remove_preproc_dir=True.

grafik

@bouweandela
Copy link
Member Author

Thanks for reviewing @schlunma!

@bouweandela bouweandela merged commit 49c65db into main Apr 21, 2022
@bouweandela bouweandela deleted the fix-results-webpage branch April 21, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some plots are not shown on index.html even though provenance information looks fine
2 participants