-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DKRZ-Levante #1558
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 197 197
Lines 10572 10572
=======================================
Hits 9596 9596
Misses 976 976 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As a suggestion, for more consistency we could use
CMIP6: /work/bd0854/DATA/ESMValTool2/CMIP6_DKRZ
instead of
CMIP6: /work/ik1017/CMIP6/data/CMIP6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @remi-kazeroni!
Please copy the content of this file to ESMValTools config-user.yml
file in another PR once this is merged so that we keep these two files synchronized 👍
Thanks! I have opened in PR in ESMValGroup/ESMValTool#2632 Please merge both PRs if both look good to you 👍 |
Description
This PR adds an entry to the config-user.yml file for Levante. It gives all the paths to the data on Levante. Also, it adds info about a shared directory for the automatically downloaded data (read/write access for members of the ESMValTool development project only).
I suggest to keep the Mistral entry for as long as the machine is available.
Once this is merged, it would be good to sync with the https://github.com/ESMValGroup/ESMValTool/blob/main/config-user-example.yml
Related to ESMValGroup/ESMValTool#2631
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Unit tests have been added~~- [ ] 🛠 Changes are backward compatible
- [ ] 🛠 Any changed dependencies have been added or removed correctly- [ ] 🛠 The list of authors is up to dateTo help with the number pull requests: