Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DKRZ-Levante #1558

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Add support for DKRZ-Levante #1558

merged 2 commits into from
Apr 12, 2022

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Apr 12, 2022

Description

This PR adds an entry to the config-user.yml file for Levante. It gives all the paths to the data on Levante. Also, it adds info about a shared directory for the automatically downloaded data (read/write access for members of the ESMValTool development project only).

I suggest to keep the Mistral entry for as long as the machine is available.

Once this is merged, it would be good to sync with the https://github.com/ESMValGroup/ESMValTool/blob/main/config-user-example.yml

Related to ESMValGroup/ESMValTool#2631

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@remi-kazeroni remi-kazeroni added the documentation Improvements or additions to documentation label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1558 (1449af0) into main (63351c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1558   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         197      197           
  Lines       10572    10572           
=======================================
  Hits         9596     9596           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63351c2...1449af0. Read the comment docs.

@remi-kazeroni remi-kazeroni self-assigned this Apr 12, 2022
@remi-kazeroni remi-kazeroni added this to the v2.6.0 milestone Apr 12, 2022
Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As a suggestion, for more consistency we could use

CMIP6: /work/bd0854/DATA/ESMValTool2/CMIP6_DKRZ
instead of
CMIP6: /work/ik1017/CMIP6/data/CMIP6

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @remi-kazeroni!

Please copy the content of this file to ESMValTools config-user.yml file in another PR once this is merged so that we keep these two files synchronized 👍

@remi-kazeroni
Copy link
Contributor Author

Looks good, thanks @remi-kazeroni!

Please copy the content of this file to ESMValTools config-user.yml file in another PR once this is merged so that we keep these two files synchronized 👍

Thanks! I have opened in PR in ESMValGroup/ESMValTool#2632 Please merge both PRs if both look good to you 👍

@schlunma schlunma merged commit b09dde2 into main Apr 12, 2022
@schlunma schlunma deleted the add_support_levante branch April 12, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants