Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed package/meta.yml #1540

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Removed package/meta.yml #1540

merged 4 commits into from
Mar 22, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 15, 2022

This PR removes package/meta.yml as dicussed in #1522.

Closes #1362
Related to #1522

Documentation: https://esmvaltool--1540.org.readthedocs.build/projects/ESMValCore/en/1540/contributing.html#making-a-release


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the installation Installation problem label Mar 15, 2022
@schlunma schlunma added this to the v2.6.0 milestone Mar 15, 2022
@schlunma schlunma self-assigned this Mar 15, 2022
@zklaus
Copy link

zklaus commented Mar 15, 2022

To me, these two things seem to be too unrelated to be in the same PR. Please consider splitting it up.

@schlunma
Copy link
Contributor Author

While unpinning iris in meta.yml I remembered that we wanted to remove this, that's how these two things ended up in the same PR.

It's basically two lines of code that change and one file that is removed. Is it really necessary to split this up? I also thought we already agreed on both changes?

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1540 (1aec48a) into main (2acbbf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         197      197           
  Lines       10568    10568           
=======================================
  Hits         9592     9592           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acbbf4...1aec48a. Read the comment docs.

@bouweandela
Copy link
Member

Don't forget to update the documentation on making a release and the contribution guidelines

@schlunma
Copy link
Contributor Author

Don't forget to update the documentation on making a release and the contribution guidelines

Yes, was just about to do that. It makes sense to split the PR in that case.

I would need some input from someone who already manually published a conda package on this, I have no idea how this needs to be modified.

@bouweandela
Copy link
Member

I would need some input from someone who already manually published a conda package on this, I have no idea how this needs to be modified.

It should be replaced with instructions on how to update the conda-forge feedstock. We're no longer publishing to the esmvalgroup channel.

@bouweandela
Copy link
Member

@schlunma schlunma changed the title Unpinned iris and removed package/meta.yml Removed package/meta.yml Mar 16, 2022
@schlunma
Copy link
Contributor Author

schlunma commented Mar 16, 2022

I removed all appearances of package/meta.yaml and updated the release instructions accordingly.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, cheers, Manu! Alas, I reckon we should be a bit more verbose about the instructions re: feedstock, but it's prob best to keep them short for now, since future release managers would need some coaching anyway - what you think @zklaus - briefer documentation and more on-the-job coaching or the other way round?

@schlunma
Copy link
Contributor Author

schlunma commented Mar 16, 2022

I will merge this after @bouweandela had a look at this 👍

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this!

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@schlunma schlunma merged commit 99fbe3c into main Mar 22, 2022
@schlunma schlunma deleted the remove_metayml_unpin_iris branch March 22, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove our own-grown conda package
4 participants