-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed package/meta.yml
#1540
Removed package/meta.yml
#1540
Conversation
To me, these two things seem to be too unrelated to be in the same PR. Please consider splitting it up. |
While unpinning It's basically two lines of code that change and one file that is removed. Is it really necessary to split this up? I also thought we already agreed on both changes? |
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 197 197
Lines 10568 10568
=======================================
Hits 9592 9592
Misses 976 976 Continue to review full report at Codecov.
|
Don't forget to update the documentation on making a release and the contribution guidelines |
Yes, was just about to do that. It makes sense to split the PR in that case. I would need some input from someone who already manually published a conda package on this, I have no idea how this needs to be modified. |
It should be replaced with instructions on how to update the conda-forge feedstock. We're no longer publishing to the esmvalgroup channel. |
This section would also need an update: https://docs.esmvaltool.org/projects/esmvalcore/en/latest/contributing.html#dependencies |
package/meta.yml
package/meta.yml
I removed all appearances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, cheers, Manu! Alas, I reckon we should be a bit more verbose about the instructions re: feedstock, but it's prob best to keep them short for now, since future release managers would need some coaching anyway - what you think @zklaus - briefer documentation and more on-the-job coaching or the other way round?
I will merge this after @bouweandela had a look at this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking care of this!
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
This PR removes
package/meta.yml
as dicussed in #1522.Closes #1362
Related to #1522
Documentation: https://esmvaltool--1540.org.readthedocs.build/projects/ESMValCore/en/1540/contributing.html#making-a-release
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: