Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #1521

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Updated dependencies #1521

merged 1 commit into from
Mar 3, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 3, 2022

See discussion here conda-forge/esmvalcore-feedstock#33.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the installation Installation problem label Mar 3, 2022
@schlunma schlunma added this to the v2.5.0 milestone Mar 3, 2022
@schlunma schlunma requested review from zklaus and valeriupredoi March 3, 2022 13:11
@schlunma
Copy link
Contributor Author

schlunma commented Mar 3, 2022

I noticed that the recipe from the feedstock repository deviates quite a lot from package/meta.yml. Would it make sense to unify those?

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #1521 (131a0da) into main (5babb91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         197      197           
  Lines       10552    10552           
=======================================
  Hits         9576     9576           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5babb91...131a0da. Read the comment docs.

@zklaus
Copy link

zklaus commented Mar 3, 2022

I think we decided to just get rid of package/meta.yml, but I am not sure if this is already documented somewhere.

@valeriupredoi
Copy link
Contributor

probably just in the minutes of the last TechLead call - I reckon we shouldn't bother with this file n more 👍

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, Manu 🍺

@schlunma
Copy link
Contributor Author

schlunma commented Mar 3, 2022

I think we decided to just get rid of package/meta.yml, but I am not sure if this is already documented somewhere.

Yes, I also think we did that. How about we target that for v2.6? I will open an issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants