Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed output messages for CMOR logging #1494

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fixed output messages for CMOR logging #1494

merged 1 commit into from
Feb 16, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 16, 2022

Description

Fixes log formatting of CMOR messages.

Closes #1492

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Feb 16, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1494 (f8bfd5a) into main (4fb6b79) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files         197      197           
  Lines       10517    10517           
=======================================
  Hits         9541     9541           
  Misses        976      976           
Impacted Files Coverage Δ
esmvalcore/cmor/check.py 97.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb6b79...f8bfd5a. Read the comment docs.

@schlunma schlunma self-assigned this Feb 16, 2022
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to my heart - proper detail oriented 😁 Thanks, Manu!

@schlunma schlunma merged commit 51a8a02 into main Feb 16, 2022
@schlunma schlunma deleted the fix_cmor_messages branch February 16, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting of CMOR errors is broken
2 participants