Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off conda lock file creation on any push on main branch from Github Action test #1489

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 14, 2022

Description

Deps change very often and the conda lock file gets updated way too many times with every push on main - this is not something bad, since the lock file gets recreated many times (even a day) which is good, but it is rather annoying, and we risk the github-actions bot to be one of our main contributors, which is ridiculous 😆


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1489 (e5108c1) into main (ae1f43f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files         197      197           
  Lines       10517    10517           
=======================================
  Hits         9541     9541           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1f43f...e5108c1. Read the comment docs.

@schlunma schlunma added this to the v2.5.0 milestone Feb 14, 2022
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@valeriupredoi
Copy link
Contributor Author

cheers, Manu! Bot is getting demoted 😆

@valeriupredoi valeriupredoi merged commit ee7c0d9 into main Feb 14, 2022
@valeriupredoi valeriupredoi deleted the turn_off_condalock_creation_on_push branch February 14, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants