Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed usage of statistics=std_dev option in multi-model statistics preprocessors #1478

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 7, 2022

Description

Fixes an issue with the multi_model_statistic option statistic=std_dev introduced with #673.

Closes #1475
Related to ESMValGroup/ESMValTool#2521

Link to documentation: https://esmvaltool--1478.org.readthedocs.build/projects/ESMValCore/en/1478/recipe/preprocessor.html#multi-model-statistics


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Feb 7, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 7, 2022
@schlunma schlunma self-assigned this Feb 7, 2022
@schlunma schlunma changed the title Fix std dev Fixed usage of statistics=std_dev option in multi-model statistics preprocessors Feb 7, 2022
Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

Thanks Saskia! This also fixes the scipy issue in the doc build

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🅱️ oss level 👍

@schlunma schlunma merged commit 2287851 into main Feb 7, 2022
@schlunma schlunma deleted the fix_std_dev branch February 7, 2022 16:29
@valeriupredoi
Copy link
Contributor

do you mind doing the same for Tool pls 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scipy upgrade breaks our documentation builds
3 participants