Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased ESMValCore version to 2.5.0rc1 #1477

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 7, 2022

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the documentation Improvements or additions to documentation label Feb 7, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 7, 2022
@schlunma schlunma self-assigned this Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1477 (3aa16b3) into main (2287851) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1477   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         196      196           
  Lines       10473    10473           
=======================================
  Hits         9409     9409           
  Misses       1064     1064           
Impacted Files Coverage Δ
esmvalcore/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2287851...3aa16b3. Read the comment docs.

@schlunma schlunma marked this pull request as ready for review February 7, 2022 16:40
@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

I think this can be merged now

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but @zklaus and @valeriupredoi are the experts here.

Question: is the next step to uncomment this line in the environment file of the Tool?

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

Looks fine to me but @zklaus and @valeriupredoi are the experts here.

Question: is the next step to uncomment this line in the environment file of the Tool?

Yes, I will do this after the release, but probably tomorrow (so hopefully the pip and conda package built successfully).

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, gents 👍 🍺

@schlunma
Copy link
Contributor Author

schlunma commented Feb 7, 2022

Thanks V.! 🍻

@schlunma schlunma merged commit c788735 into main Feb 7, 2022
@schlunma schlunma deleted the update_version_v2.5.0rc1 branch February 7, 2022 16:55
@valeriupredoi
Copy link
Contributor

next step to uncomment this line in the environment file of the Tool?

Yis, but only after the (pre-)release has gone through and you guys are all happy it works fine (eg see conda deployment done, installation from both conda and pip work fine for Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants