-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased ESMValCore version to 2.5.0rc1 #1477
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1477 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 196 196
Lines 10473 10473
=======================================
Hits 9409 9409
Misses 1064 1064
Continue to review full report at Codecov.
|
I think this can be merged now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but @zklaus and @valeriupredoi are the experts here.
Question: is the next step to uncomment this line in the environment file of the Tool?
Yes, I will do this after the release, but probably tomorrow (so hopefully the pip and conda package built successfully). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, gents 👍 🍺
Thanks V.! 🍻 |
Yis, but only after the (pre-)release has gone through and you guys are all happy it works fine (eg see conda deployment done, installation from both conda and pip work fine for Core) |
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: