Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that caused automatic download to fail in rare cases #1442

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 27, 2022

Description

This PR fixes a bug in the automatic download feature that led to weird error messages. It assigns median_speed = 0.0 if no non-zero values for the download speed can be found from past runs. This avoids cryptic error messages that result from using the download feature on a node without internet connection.

Closes #1440


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Jan 27, 2022
@schlunma schlunma added this to the v2.5.0 milestone Jan 27, 2022
@schlunma schlunma requested a review from bouweandela January 27, 2022 16:57
@schlunma schlunma self-assigned this Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1442 (609456b) into main (2d3df9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   89.65%   89.66%           
=======================================
  Files         196      196           
  Lines       10336    10339    +3     
=======================================
+ Hits         9267     9270    +3     
  Misses       1069     1069           
Impacted Files Coverage Δ
esmvalcore/esgf/_download.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3df9d...609456b. Read the comment docs.

@schlunma schlunma merged commit b033cd7 into main Jan 28, 2022
@schlunma schlunma deleted the fix_download branch January 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic download fails in rare cases
2 participants