Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .pymon-journal file in test discovery #1436

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 25, 2022

Description

Sister PR to Tool's ESMValGroup/ESMValTool#2491 that was a result from issue ESMValGroup/ESMValTool#2489 - thanks to @zklaus for noticing this and fixing it in Tool, his description:

Sometimes (relatively frequently), the monitor tests fail because pytests discovery stumbles over what looks like a temporary file from pytest-monitor. This PR adds an explicit ignore for that file.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added bug Something isn't working testing labels Jan 25, 2022
@valeriupredoi valeriupredoi requested a review from zklaus January 25, 2022 15:31
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1436 (818f4dd) into main (6b119db) will not change coverage.
The diff coverage is n/a.

❗ Current head 818f4dd differs from pull request most recent head 322e338. Consider uploading reports for the commit 322e338 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         196      196           
  Lines       10336    10336           
=======================================
  Hits         9267     9267           
  Misses       1069     1069           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b119db...322e338. Read the comment docs.

Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting it to the core, @valeriupredoi! Once the tests are green, the branch can be removed from the triggering and it's ready.

@valeriupredoi
Copy link
Contributor Author

cheers @zklaus 🍺

@valeriupredoi valeriupredoi merged commit 875a3fa into main Jan 25, 2022
@valeriupredoi valeriupredoi deleted the ignore_pymon_journal branch January 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants