Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct brackets in preprocessor documentation for list of seasons #1420

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 6, 2022

Description

The brackets used in the documentation of the seasons argument to several preprocessor functions were not a valid way to create a list in YAML. This pull request fixes the problem.

Link to documentation: https://esmvaltool--1420.org.readthedocs.build/projects/ESMValCore/en/1420/recipe/preprocessor.html#seasonal-statistics


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the documentation Improvements or additions to documentation label Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1420 (595e721) into main (ffa16c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         196      196           
  Lines       10234    10234           
=======================================
  Hits         9144     9144           
  Misses       1090     1090           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa16c4...595e721. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HNY @bouweandela - cheers for this very short and biutiful PR (I really didn't want to start the new year with a 4,000-line PR 🤣 )

@bouweandela bouweandela merged commit 2fc6a19 into main Jan 7, 2022
@bouweandela bouweandela deleted the doc-seasons-brackets branch January 7, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants