Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed custom version of AtmosphereSigmaFactory #1382

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 3, 2021

Description

iris 3.1 added support for AtmosphereSigmaFactory (SciTools/iris#4052). For this reason we can remove our custom version of it.

Closes #1380 (Needs also changes in ESMValTool)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1382 (448435c) into main (6d9e4b9) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   88.39%   88.61%   +0.22%     
==========================================
  Files         195      195              
  Lines        9958     9867      -91     
==========================================
- Hits         8802     8744      -58     
+ Misses       1156     1123      -33     
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py 100.00% <ø> (ø)
esmvalcore/cmor/_fixes/shared.py 100.00% <ø> (+12.78%) ⬆️
esmvalcore/cmor/_fixes/cmip5/fgoals_g2.py 100.00% <100.00%> (ø)
esmvalcore/cmor/fixes.py 100.00% <100.00%> (ø)
esmvalcore/preprocessor/_io.py 86.55% <100.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9e4b9...448435c. Read the comment docs.

@schlunma schlunma marked this pull request as ready for review November 3, 2021 14:23
@schlunma schlunma requested a review from jvegreg as a code owner November 3, 2021 14:23
@schlunma schlunma modified the milestones: v2.4.1, v2.4.0 Nov 3, 2021
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for taking care of this @schlunma!

@schlunma schlunma merged commit 9633b3d into main Nov 3, 2021
@schlunma schlunma deleted the remove_atmosphere_sigma_coordinate branch November 3, 2021 16:02
@zklaus zklaus added the bug Something isn't working label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iris module error when running recipe_ecs_constraints.yml
3 participants