Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 2.4.0 #1366

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Update changelog for 2.4.0 #1366

merged 2 commits into from
Oct 18, 2021

Conversation

zklaus
Copy link

@zklaus zklaus commented Oct 18, 2021

Description

This updates the changelog for version 2.4.0 to rc1 status


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@zklaus zklaus added the documentation Improvements or additions to documentation label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1366 (4f425bf) into main (bfb2fba) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f425bf differs from pull request most recent head 5bf8144. Consider uploading reports for the commit 5bf8144 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         195      195           
  Lines        9943     9943           
=======================================
  Hits         8787     8787           
  Misses       1156     1156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb2fba...5bf8144. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, man! may want to remove the Notebook/API section if there's nothing in there, also - did we not want to have Highlights in?

@zklaus zklaus marked this pull request as ready for review October 18, 2021 09:24
@zklaus
Copy link
Author

zklaus commented Oct 18, 2021

Good call on the empty section. I think we should add the highlights for the final release and not yet for the release candidate.

@valeriupredoi
Copy link
Contributor

sounds good, man 🍺

@zklaus zklaus merged commit 639e5ab into main Oct 18, 2021
@zklaus zklaus deleted the update-changelog branch October 18, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants