Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra facets #1360

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Fix extra facets #1360

merged 2 commits into from
Oct 15, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Oct 15, 2021

Description

Closes #1355


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the bug Something isn't working label Oct 15, 2021
@bouweandela bouweandela added this to the v2.4.0 milestone Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1360 (3e53b5b) into main (3c3f5cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         194      194           
  Lines        9836     9836           
=======================================
  Hits         8682     8682           
  Misses       1154     1154           
Impacted Files Coverage Δ
esmvalcore/_config/_config.py 95.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f5cb...3e53b5b. Read the comment docs.

@bouweandela bouweandela merged commit 9e024ad into main Oct 15, 2021
@bouweandela bouweandela deleted the fix-extra-facets branch October 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extra_facets are broken
3 participants