Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upper case to lower case variables and functions for flake compliance in tests/unit/preprocessor/_regrid/test_extract_levels.py #1347

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 8, 2021

Description

An oversight from my review of #1269 and the annoying result of flake not running until the PR is merged. I have also added the explicit import of iris.fileformats in tests/unit/preprocessor/_regrid/__init__.py so one can actually manually run each of the regrid tests with pytest (we do have an issue open for this sort of bugger).


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1347 (76660ef) into main (f47fd97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         194      194           
  Lines        9810     9810           
=======================================
  Hits         8649     8649           
  Misses       1161     1161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47fd97...76660ef. Read the comment docs.

@zklaus zklaus merged commit 73ad1a4 into main Oct 8, 2021
@zklaus zklaus deleted the fix_upper_case_flake_test_regrid branch October 8, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants