Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid fix for tos in fgoals-f3-l #1326

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Add grid fix for tos in fgoals-f3-l #1326

merged 1 commit into from
Sep 23, 2021

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Sep 22, 2021

Description

Add bounds to tos using OceanGridFix

Closes #1325

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #1326 (d3355d6) into main (f73fff9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files         188      188           
  Lines        9211     9213    +2     
=======================================
+ Hits         7994     7996    +2     
  Misses       1217     1217           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip6/fgoals_f3_l.py 86.36% <100.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73fff9...d3355d6. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work and a small PR (how I like 'em 😁 ), Saskia 👍 Can you please take care of the boxes in the PR description (remove the ones that are not relevant or strike-thru them and check all others)

@sloosvel
Copy link
Contributor Author

Done, thanks for taking a look!

@sloosvel sloosvel merged commit c2071f7 into main Sep 23, 2021
@sloosvel sloosvel deleted the dev_fix_fgoals branch September 23, 2021 09:57
@zklaus
Copy link

zklaus commented Sep 23, 2021

@valeriupredoi, @sloosvel, sorry, perhaps there was some confusion, but the checklist happens before the review. In this case, we still need some labels, please (checklist point 2). They are important because they are used for the generation of the changelog.

But nice work 😄

@sloosvel sloosvel added the fix for dataset Related to dataset-specific fix files label Sep 23, 2021
@valeriupredoi
Copy link
Contributor

yep, that's true @zklaus - I should be more bureaucratic for a guy living in Britain 🤣 Cheers, @sloosvel 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset problem: FGOALS-f3-l tos does not have lat/lon bounds
3 participants