Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize conda_install test on Circle CI by installing from conda-forge with Python 3.9 and change install instructions in documentation #1280

Merged
merged 6 commits into from
Aug 23, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Aug 20, 2021

Description

Closes #1279
conda install works fine with these changes, hopefully it'll not run out of memory anymore, at least as often as before 🍺


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1280 (c2ba2cb) into main (92371de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1280   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         188      188           
  Lines        9167     9167           
=======================================
  Hits         7920     7920           
  Misses       1247     1247           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92371de...c2ba2cb. Read the comment docs.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Could you also check that these steps are identical to the documentation?

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@valeriupredoi
Copy link
Contributor Author

Thanks for taking care of this! Could you also check that these steps are identical to the documentation?

no, good point, man - we need to remove the use of esmvalgroup channel for Core in the documentation, should I do that here or in a different PR (I'd do it in a separate PR right away if it was by me)

@bouweandela
Copy link
Member

bouweandela commented Aug 20, 2021

It would be great if you could do it here, the tests on CircleCI/GitHub Actions should always reflect the documentation. That way we are sure that the instructions in the documentation actually work.

@valeriupredoi
Copy link
Contributor Author

right on @bouweandela - will do it 'ere then 👍

@valeriupredoi valeriupredoi changed the title modernize conda_install test on Circle CI by installing from conda-forge with Python 3.9 modernize conda_install test on Circle CI by installing from conda-forge with Python 3.9 and change install instructions in documentation Aug 20, 2021
@valeriupredoi
Copy link
Contributor Author

OK Bouwe, done that, could you have a looksee pls mate, I've also changed a bit the instructions on how to build&upload the package 🍺

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@valeriupredoi
Copy link
Contributor Author

cheers @bouweandela 🍺

@valeriupredoi valeriupredoi merged commit 135fce2 into main Aug 23, 2021
@valeriupredoi valeriupredoi deleted the modernize_conda_install_circle_test branch August 23, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda_install test on Circle CI is failing often running out of available machine memory
2 participants