-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize conda_install
test on Circle CI by installing from conda-forge with Python 3.9 and change install instructions in documentation
#1280
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1280 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 188 188
Lines 9167 9167
=======================================
Hits 7920 7920
Misses 1247 1247 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! Could you also check that these steps are identical to the documentation?
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
no, good point, man - we need to remove the use of |
It would be great if you could do it here, the tests on CircleCI/GitHub Actions should always reflect the documentation. That way we are sure that the instructions in the documentation actually work. |
right on @bouweandela - will do it 'ere then 👍 |
conda_install
test on Circle CI by installing from conda-forge with Python 3.9conda_install
test on Circle CI by installing from conda-forge with Python 3.9 and change install instructions in documentation
OK Bouwe, done that, could you have a looksee pls mate, I've also changed a bit the instructions on how to build&upload the package 🍺 |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
cheers @bouweandela 🍺 |
Description
Closes #1279
conda install works fine with these changes, hopefully it'll not run out of memory anymore, at least as often as before 🍺
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: