Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around issue with yapf not following PEP8 #1277

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 20, 2021

Description

Fixes the first half of #1005

See also google/yapf#744


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1277 (de4d065) into main (b21dee8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         188      188           
  Lines        9167     9167           
=======================================
  Hits         7920     7920           
  Misses       1247     1247           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21dee8...de4d065. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we not need one [yapf] section for setup.cfg too? Cheers for fixing this, man!

@bouweandela
Copy link
Member Author

would we not need one [yapf] section for setup.cfg too?

It looks like there is one [yapf] section in setup.cfg to me, or am I missing something?

@valeriupredoi
Copy link
Contributor

would we not need one [yapf] section for setup.cfg too?

It looks like there is one [yapf] section in setup.cfg to me, or am I missing something?

Indeed, I'm officially blind 🤦‍♂️

@bouweandela bouweandela merged commit 1230d61 into main Aug 20, 2021
@bouweandela bouweandela deleted the yapf-style branch August 20, 2021 13:23
@zklaus zklaus added the documentation Improvements or additions to documentation label Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants