Make sure area_statistics preprocessor always returns original dtype #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklaus
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1239 +/- ##
=======================================
Coverage 85.54% 85.55%
=======================================
Files 188 188
Lines 9150 9156 +6
=======================================
+ Hits 7827 7833 +6
Misses 1323 1323
Continue to review full report at Codecov.
|
|
@jvegasbsc, this is essentially the same PR as for the climate_statistics (#1237) that you just reviewed, only now for area_statistics. Would you mind having a look? |
jvegreg
approved these changes
Jul 20, 2021
zklaus
pushed a commit
that referenced
this pull request
Jul 21, 2021
…1239) * Make sure area_statistics returns same dtype as input * Use consistently dtype float32 in area_statistics tests
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds code to the area_statistics preprocessor to detect whether it has changed the dtype of the cube. If this is the case, it changes the dtype back to the original dtype.
Closes #1236
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: