-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.6 #1200
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 188 188
Lines 9150 9150
=======================================
Hits 7827 7827
Misses 1323 1323 Continue to review full report at Codecov.
|
@bouweandela @zklaus we should talk about this at the meeting tomorrow 👍 |
Agree with the idea, have not yet checked the implementation. |
cool! have a look when you gots time 👍 |
Will do once we decide to go ahead with this. 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conda build is taking too long, but it looks unrelated to this pull request.
Description
Closes #1199
Related to full functionality of #1182
Tests failing due to problem fixed in #1197
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: