Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #1200

Merged
merged 9 commits into from
Jul 30, 2021
Merged

Drop support for Python 3.6 #1200

merged 9 commits into from
Jul 30, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 28, 2021

Description

Closes #1199
Related to full functionality of #1182
Tests failing due to problem fixed in #1197

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1200 (24a0249) into main (2a0bb11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files         188      188           
  Lines        9150     9150           
=======================================
  Hits         7827     7827           
  Misses       1323     1323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0bb11...24a0249. Read the comment docs.

@valeriupredoi
Copy link
Contributor Author

@bouweandela @zklaus we should talk about this at the meeting tomorrow 👍

@zklaus
Copy link

zklaus commented Jun 30, 2021

Agree with the idea, have not yet checked the implementation.

@valeriupredoi
Copy link
Contributor Author

cool! have a look when you gots time 👍

@zklaus
Copy link

zklaus commented Jul 1, 2021

Will do once we decide to go ahead with this. 🍻

@valeriupredoi
Copy link
Contributor Author

OK if we do it in 2.4 then let's just get #1182 and #1197 in and I'll just take 3.6 out the Github Action tests, basically we will have no support for it via those two PRs but not saying it explicitly in our docs and environment file

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conda build is taking too long, but it looks unrelated to this pull request.

@bouweandela bouweandela merged commit 76eb12e into main Jul 30, 2021
@bouweandela bouweandela deleted the remove_python36 branch July 30, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.6
3 participants