Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed time coordinate of MIROC-ESM #1188

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Fixed time coordinate of MIROC-ESM #1188

merged 4 commits into from
Jun 30, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 17, 2021 •
edited by zklaus
Loading

Fix time coordinate of gpp_Lmon_MIROC-ESM_esmFixClim1_r1i1p1_000101-014012.nc.

Closes #1187.

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

To help with the number pull requests:

@schlunma schlunma requested a review from jvegreg as a code owner June 17, 2021 14:26
@schlunma schlunma requested review from zklaus and removed request for jvegreg June 17, 2021 14:26
@schlunma schlunma self-assigned this Jun 17, 2021
@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Jun 17, 2021
@schlunma schlunma mentioned this pull request Jun 17, 2021
Closed
@zklaus zklaus added this to the v2.3.1 milestone Jun 23, 2021
valeriupredoi
valeriupredoi approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a wee comment needed say what those numbers are, all else good by me, cheers Manu 👍

@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #1188 (5fd8142) into main (474f71d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   85.51%   85.53%   +0.02%     
==========================================
  Files         188      188              
  Lines        9146     9159      +13     
==========================================
+ Hits         7821     7834      +13     
  Misses       1325     1325
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip5/miroc_esm.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474f71d...5fd8142. Read the comment docs.

@schlunma
Copy link
Contributor Author

Thanks for the review @valeriupredoi! Please merge when you are happy with the comments

@valeriupredoi valeriupredoi merged commit e573b5d into main Jun 30, 2021
@valeriupredoi valeriupredoi deleted the fix_miroc_esm_time branch June 30, 2021 11:49
zklaus pushed a commit that referenced this pull request Jul 7, 2021
@schlunma
Fixed time coordinate of MIRCO-ESM (#1188)
8f5b629 
* Fixed time coordinate of MIRCO-ESM

* Added comments on fix for MIROC-ESM

* Added missing test case
@zklaus zklaus changed the title Fixed time coordinate of MIRCO-ESM Fixed time coordinate of MIROC-ESM Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@zklaus zklaus Awaiting requested review from zklaus

Assignees

@schlunma schlunma

Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Milestone
v2.3.1
Development

Successfully merging this pull request may close these issues.

Dataset problem: invalid time bounds of gpp_Lmon_MIROC-ESM_esmFixClim1_r1i1p1_000101-014012.nc
3 participants
@schlunma @valeriupredoi @zklaus