-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a link to the instructions to use pre-installed versions on HPC clusters #1186
Conversation
This would only work after #2197 is merged to the ESMValTool. Please do not merge before. |
props from me 👍 |
@valeriupredoi wrote:
|
@zklaus asked:
|
@valeriupredoi replied:
|
The HPC instructions for the tool were merged in #2197 in the documentation. But these instructions do not appear in the documentation so the link I added in this PR for the Core documentation does not work. @zklaus @valeriupredoi would you know why this part is not displaed in the latest doumentation? Shall I open a separate issue for that? |
You bring up a good point that kind of surfaced already in the preparation of the core release: I, and probably most core developers, don't seem to have access to the relevant readthedocs configuration. That makes it hard to debug this kind of issue. Maybe we should widen the circle there a bit? Let's discuss at the next technical lead team meeting. |
I don't know what has changed but this issue is now solved. Yes that is something we need to put on the agenda for the next technical lead team meeting. |
@ESMValGroup/esmvaltool-coreteam would you prefer:
(For 3. the link does not work properly as I would need another commit to retrigger readthedocs but it works when I build the documentation locally). |
@zklaus Did you try logging in with your GitHub credentials? |
I clicked the rebuild button on the readthedocs builds page and the link works correctly now. |
Yes, I did. I can see other github projects, but the ESMValGroup ones are not listed. If I navigate manually to ESMValCore, the "Admin" button is missing. |
@zklaus I added you as a maintainer for the ESMValCore and ESMValTool readthedocs projects, you should have the button now. |
Jepp, that worked. Thanks, @bouweandela! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me, cheers @remi-kazeroni - does the link work well?
Yes the documentation works fine. Thanks for the approval @valeriupredoi 👍 |
Description
We are about to move the instructions to use pre-installed version of the ESMValTool on HPC clusters to the ESMValTool documentation in #2197. To avoid duplicating the instructions, the ESMValCore documention on the topic is replaced by a link to the same instructions in the ESMValTool documentation. This would offer better visibility for the pre-installed version (see comment).
Closes #989
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Unit tests have been addedTo help with the number pull requests: