Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the instructions to use pre-installed versions on HPC clusters #1186

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Jun 17, 2021

Description

We are about to move the instructions to use pre-installed version of the ESMValTool on HPC clusters to the ESMValTool documentation in #2197. To avoid duplicating the instructions, the ESMValCore documention on the topic is replaced by a link to the same instructions in the ESMValTool documentation. This would offer better visibility for the pre-installed version (see comment).

Closes #989

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@remi-kazeroni remi-kazeroni added the documentation Improvements or additions to documentation label Jun 17, 2021
@remi-kazeroni remi-kazeroni self-assigned this Jun 17, 2021
@remi-kazeroni
Copy link
Contributor Author

This would only work after #2197 is merged to the ESMValTool. Please do not merge before.

@valeriupredoi
Copy link
Contributor

props from me 👍

@remi-kazeroni
Copy link
Contributor Author

@valeriupredoi wrote:

I think we should probably leave the doc in ESMValCore too just so people that want to use only Core functionality can do that, but it's becoming a nuisance to make sure that the two sets of doc are in sync so if you decide to remove it from Core docs as @zklaus suggests, I won't make a fuss of it 😁

@remi-kazeroni
Copy link
Contributor Author

@zklaus asked:

Is that even technically an option? Can you do module load esmvalcore?

@remi-kazeroni
Copy link
Contributor Author

@valeriupredoi replied:

no, but you can import esmvalcore modules and use them in your work

@remi-kazeroni
Copy link
Contributor Author

The HPC instructions for the tool were merged in #2197 in the documentation. But these instructions do not appear in the documentation so the link I added in this PR for the Core documentation does not work. @zklaus @valeriupredoi would you know why this part is not displaed in the latest doumentation? Shall I open a separate issue for that?

@remi-kazeroni remi-kazeroni marked this pull request as ready for review June 23, 2021 15:09
@remi-kazeroni remi-kazeroni marked this pull request as draft June 23, 2021 15:11
@zklaus
Copy link

zklaus commented Jun 23, 2021

You bring up a good point that kind of surfaced already in the preparation of the core release: I, and probably most core developers, don't seem to have access to the relevant readthedocs configuration. That makes it hard to debug this kind of issue. Maybe we should widen the circle there a bit? Let's discuss at the next technical lead team meeting.

@remi-kazeroni
Copy link
Contributor Author

You bring up a good point that kind of surfaced already in the preparation of the core release: I, and probably most core developers, don't seem to have access to the relevant readthedocs configuration. That makes it hard to debug this kind of issue. Maybe we should widen the circle there a bit? Let's discuss at the next technical lead team meeting.

I don't know what has changed but this issue is now solved. Yes that is something we need to put on the agenda for the next technical lead team meeting.

@remi-kazeroni remi-kazeroni marked this pull request as ready for review June 24, 2021 11:53
@zklaus zklaus added this to the v2.4.0 milestone Jun 24, 2021
@remi-kazeroni
Copy link
Contributor Author

remi-kazeroni commented Jun 24, 2021

@ESMValGroup/esmvaltool-coreteam would you prefer:

  1. Duplicating the instructions for the Core and the Tool as done currently
  2. Having only the intructions for the Tool
  3. Having a link to the Tool instructions as done in this PR.

(For 3. the link does not work properly as I would need another commit to retrigger readthedocs but it works when I build the documentation locally).

@bouweandela
Copy link
Member

You bring up a good point that kind of surfaced already in the preparation of the core release: I, and probably most core developers, don't seem to have access to the relevant readthedocs configuration. That makes it hard to debug this kind of issue. Maybe we should widen the circle there a bit? Let's discuss at the next technical lead team meeting.

@zklaus Did you try logging in with your GitHub credentials?

@bouweandela
Copy link
Member

I clicked the rebuild button on the readthedocs builds page and the link works correctly now.

@zklaus
Copy link

zklaus commented Jun 27, 2021

@zklaus Did you try logging in with your GitHub credentials?

Yes, I did. I can see other github projects, but the ESMValGroup ones are not listed. If I navigate manually to ESMValCore, the "Admin" button is missing.

@bouweandela
Copy link
Member

@zklaus I added you as a maintainer for the ESMValCore and ESMValTool readthedocs projects, you should have the button now.

@zklaus
Copy link

zklaus commented Jun 29, 2021

Jepp, that worked. Thanks, @bouweandela!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me, cheers @remi-kazeroni - does the link work well?

@remi-kazeroni
Copy link
Contributor Author

OK by me, cheers @remi-kazeroni - does the link work well?

Yes the documentation works fine. Thanks for the approval @valeriupredoi 👍

@remi-kazeroni remi-kazeroni merged commit 197a9a1 into main Jul 13, 2021
@remi-kazeroni remi-kazeroni deleted the fix_hpc_module_documentation branch July 13, 2021 07:30
zklaus pushed a commit that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation on how to source and run/use esmvaltool from HPC central installations
4 participants