-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve finding date range in filenames (enforces separators) #1145
Conversation
Note : this is a fast fix for V3.2.0, the proposal in #1078 should bring a more comprehensive solution, albeit probably later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Minor comments.
Oh I forgot to comment on the list of authors. This definitely grounds for adding your name. Go ahead! |
@zklaus : I do not understand the codacy status for this PR : there were issues in two old commits but there is no more yet. Can you explain ? |
@senesis, sorry about the codacy thing. I think this happened because yesterday we renamed the One last thing: You removed a bunch of information from the |
For the zenodo.json file, I applied the procedure described in the doc, noticed the large changes, and assumed that this was due to a change in what the procedure is supposed to produce. Would you like me to restore the discarded part ? |
@zklaus : The list of commits for this PR is definitely much longer than suitable. Is there a way to aggregate them in a single one without creating a new branch and a new PR ? |
On the list of commits, let me first point out that we squash on merge. That means, no matter what happens in this branch and PR, when it is merged into master it will be put in as a single commit and that is the only way how it will appear in the history from that point on. So maybe in light of this, you are ok with the state of things? I personally wouldn't worry about it. On the zenodo file, I am not sure, to be honest. @bouweandela, or perhaps @nielsdrost, could you please weigh in? It seems the way we instruct people to add themselves to the author list, we lose project and grant information from our zenodo record. Is this correct? |
OK re. the list of commits. I expected that this squeeze occurs |
Yes, please! If you have the time, it would be great if you could also add the omission in the documentation. This ifnromation is used to fill the Grants and Communities sections that you see listed on the right hand side on our zenodo page: https://zenodo.org/record/4525749 |
Hello @bouweandela and @zklaus |
Description
Closes #1127
Function get_start_end_year(filename) has flaws, as described in #1127
The change makes use of regexp to better match date range syntax in filenames.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: