Fix for pr of EC_EARTH #1116
Merged
Fix for pr of EC_EARTH #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-kazeroni
added
AR6
| except iris.exceptions.CoordinateNotFoundError: | ||
| pass | ||
|
|
||
| return new_list |
There was a problem hiding this comment.
@remi-kazeroni a bit of a style note - it's best to have a try/except clause with as little code to try as possible - just one try condition gets executed anyway, and it also looks more readable: try: single clause on one line / except (not clause): raise
There was a problem hiding this comment.
@valeriupredoi I have modified the fix to take your suggestion into account. Would that work for you now?
|
I mark this PR as RfR even if the tests are failing. I have tried to cover 3 cases:
|
|
Tests are now fixed. @valeriupredoi would you have a moment to review this PR? This is my last IPCC related fix. It would be great if we could have it in the next release but I understand this is short notice 😬 |
valeriupredoi
approved these changes
Jun 7, 2021
| except iris.exceptions.CoordinateNotFoundError: | ||
| pass | ||
|
|
||
| return new_list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes erroneously duplicated points in the time coordinate for the last file (time range 2000-2009).
Closes #1111
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: