Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounds after reversing coordinate values #1061

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Mar 26, 2021

Description

This pull request flips back the coordinate bounds if they have been reversed when checking the coordinate direction


Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@sloosvel sloosvel added bug Something isn't working cmor Related to the CMOR standard labels Mar 26, 2021
@sloosvel sloosvel requested a review from jvegreg March 26, 2021 15:12
@sloosvel
Copy link
Contributor Author

Actually I am not sure if this is right, or if it's a weird issue with a specific dataset. I'll check and close it if that is the case.

@sloosvel sloosvel marked this pull request as draft March 29, 2021 09:55
@sloosvel
Copy link
Contributor Author

So it is indeed a bug, but the implementation in the first commit was not quite right. This should do it.

@sloosvel sloosvel marked this pull request as ready for review March 29, 2021 10:37
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, cheers @sloosvel

@valeriupredoi
Copy link
Contributor

So it is indeed a bug, but the implementation in the first commit was not quite right. This should do it.

If this is a bug generalized to all datasets, then it's good to go 👍

@sloosvel
Copy link
Contributor Author

@jvegasbsc we need this for some obs data! And @valeriupredoi thinks it's good to go.

@jvegreg jvegreg merged commit 6223661 into master Apr 23, 2021
@jvegreg jvegreg deleted the dev_fix_coord_flip branch April 23, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmor Related to the CMOR standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reversing coordinates using iris.util.reverse flips the bounds incorrectly
3 participants