Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines #1047

Merged
merged 21 commits into from
Apr 1, 2021
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Mar 16, 2021

Description

This pull request updates the contribution guidelines and the pull request template.

Closes #issue_number

Link to documentation: https://esmvaltool--1047.org.readthedocs.build/projects/ESMValCore/en/1047/contributing.html


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the documentation Improvements or additions to documentation label Mar 16, 2021
@bouweandela bouweandela marked this pull request as ready for review March 24, 2021 16:07
@bouweandela bouweandela requested a review from nielsdrost March 24, 2021 16:07
Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bouweandela! One small comment (feel free to ignore) on a section with no intro or description, other than that good to go I think.

@bouweandela
Copy link
Member Author

The scipy documentation appears to be offline, causing the documentation test on CircleCI to fail.

@bouweandela bouweandela merged commit 9791061 into master Apr 1, 2021
@bouweandela bouweandela deleted the doc-contribution-guidelines branch April 1, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants