Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newer Python versions in OSX to Github Actions #1035

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Conversation

bvreede
Copy link
Contributor

@bvreede bvreede commented Mar 5, 2021

To make sure that recently fixed tests (and other issues) are run on OSX as well as Linux, newer versions of Python (3.8 and 3.9) are added to Github Actions.

Follows up on #1003

NB: the Anaconda Publish action fails, which it does on Master too, e.g. @ESMValGroup/esmvaltool-coreteam


Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@bvreede bvreede added enhancement New feature or request testing labels Mar 5, 2021
@bouweandela
Copy link
Member

NB: the Anaconda Publish action fails, which it does on Master too, e.g. @ESMValGroup/esmvaltool-coreteam

Reported it in #1036

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @bvreede - could you please first test all the additional actions (for 3.9) in a test branch - like the ga_test one you've already added, then post the pass/fails here, and if all passes fine, remove that test branch from the triggers' list and then I will approve and it'll be ready to go. Sorry, am requesting changes now only for this technicality, the changes look perfect! 🍺

@bvreede
Copy link
Contributor Author

bvreede commented Mar 8, 2021

Thanks very much @valeriupredoi! We did that already, if I understand you correctly. I just added the current branch as a trigger in the relevant actions, is that what you mean? In any case, the actions were run on this branch (though I see now that the last time this was done, the tests failed on Python OSX 3.7 — not one we added, and tests have been off and on failing on random systems, it must be the weather. Still, will double check).

I removed it in all but one (relevant) action here.

All actions passed, except Anaconda Publish, as mentioned. I'm waiting for that one to function again on master before I confirm that this branch does not add failures (hence the draft status of this PR ;))

@valeriupredoi
Copy link
Contributor

cheers @bvreede - good stuff! You can filter the actions on branch name - here the results filtered only on ga_osx https://github.com/ESMValGroup/ESMValCore/actions?query=branch%3Aga_osx (verbose link) which I should have looked at myself before asking you to instate such a test branch. Cool! They run fine - bar the segfault which is common and the circular import issue preventing conda build tests to pass (which I fixed in the other PR). Now, could you pls remove the ga_osx from the workflow files and after that we're good to go! Cheers 🍺

@bvreede bvreede marked this pull request as ready for review March 9, 2021 09:15
@bvreede
Copy link
Contributor Author

bvreede commented Mar 9, 2021

OK done — perhaps best to merge this now & I'll keep a close eye on the Anaconda Publish action.

@valeriupredoi
Copy link
Contributor

excellent work @bvreede cheers muchly! 🍺

@valeriupredoi valeriupredoi merged commit 9f603be into master Mar 9, 2021
@valeriupredoi valeriupredoi deleted the ga_osx branch March 9, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants