Switch to running the Github Action test workflow every 3 hours in single thread mode to observe if Sementation Faults occur #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefsmeets
approved these changes
Feb 25, 2021
Comment on lines
+31
to
+32
| # - cron: '0 0 * * *' # nightly | ||
| - cron: '0 */3 * * *' # every 3 hours |
There was a problem hiding this comment.
Are you going to change this back? Otherwise I'd suggest to just replace the line:
Suggested change
| # - cron: '0 0 * * *' # nightly | |
| - cron: '0 */3 * * *' # every 3 hours | |
| - cron: '0 */3 * * *' # every 3 hours |
There was a problem hiding this comment.
yeah no, gonna change it back, we really don't want to run that test every 3h for the rest of our time 😁
|
cheers @stefsmeets 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to gather enough statistic to prove that if we run the test in single thread mode we will not see the Segmentation Faults we've been seeing for nearly a year now. So to do that I want to have the GA run the test only workflow every three hours; unfortunately it's not possible to have this done on a branch, it has to be the main branch, but we can let this go for a few days, gather enough statistic then revert to the nightly run as we had it so far. If this is true then we can do what @stefsmeets suggests in this comment and hopefully rid ourselves of those pesty SegFaults for good. Please see logic behind this PR in #1020