Complete CCPPIzation of Hack shallow convection; dycore tests change to ne3pg3; FCAM4 test #362
Conversation
|
Holding as draft until I finish testing and documenting that the CAM4 tests will likely not run because all the snapshot variables are missing and model would crash (#359) |
jimmielin
force-pushed
the
hplin/hk_conv_rebase
branch
from
45b4c49 to
dd09b41
Compare
|
Needs #365 to be merged in first |
|
Updated to |
Hmmm... Maybe you need to rerun git-fleximod? Or get a clean checkout? Peeking at your tests, it looks like they match the old (pre-externals-update) baselines. Let me know if it still isn't working though. Could be a me issue for sure! |
|
Thanks @peverwhee! Strange, I had made a clean checkout. The baseline changes are related to CAM4/CAM7 suite updates and are expected, so that's all good. I'm not sure if the NLCOMP changes are expected - they appear to be related to externals, maybe? (false alarm!) |
|
@jimmielin bummer. Yeah, the namelist differences are what concern me. For some reason, my baselines had different namelists... Sounds like a me issue! |
|
@jimmielin oh. Looking at the git log of your local clone on derecho, your branch isn't at the head of CAM-SIMA development. Once you merge up, those NLCOMP failures should go away. Apologies if you already knew all of this and I'm just catching up. |
|
Ohhh my bad @peverwhee! False alarm I guess - sorry for the trouble. I will rerun the SIMA tests to be sure but I think this will fix it! |
|
@peverwhee just confirmed that there are no NLCOMP issues after merging to head of CAM-SIMA. Sorry for the false alarm! |
There was a problem hiding this comment.
Thanks @jimmielin! I just have one small request (but I don't think it needs a re-review).
src/data/registry.xml
Outdated
| <variable local_name="delt" | ||
| standard_name="half_timestep_for_physics" | ||
| units="s" type="real" kind="kind_phys"> | ||
| </variable> |
There was a problem hiding this comment.
Is this needed? I don't think ZM actually uses a half-physics timestep.
There was a problem hiding this comment.
Thanks @jimmielin I have a couple of questions in the registry, but nothing that prevents my approval!
|
SIMA regression tests:
|
jimmielin
changed the title
Tag name (required for release branches): sima0_04_000
Originator(s): jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
SIMA regression tests:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: