This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Switching to browser compatible .toArrayLike #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting tests to avoid duplicate transactions
src/tests/node.test.ts
Outdated
| @@ -6,7 +6,7 @@ describe('Node JS environment', () => { | |||
| let failedAsPlanned: boolean; | |||
|
|
|||
| beforeEach(async () => { | |||
| await new Promise((resolve) => setTimeout(resolve, 500)); | |||
| await new Promise((resolve) => setTimeout(resolve, 1500)); | |||
There was a problem hiding this comment.
Why the need to increase timeouts?
There was a problem hiding this comment.
On second thought, we could possibly change the memo or quantity to avoid duplicate transaction more reliably and without additional time during tests.
There was a problem hiding this comment.
So with it at 500ms, you were getting duplicate transactions?
There was a problem hiding this comment.
The web tests were getting duplicates at 1000ms, I increased that one and brought the node tests to the same amount. Can't recall if I also got duplicates in node with 500.
bradlhart
force-pushed
the
bnjs-tobuffer-incompatible
branch
from
67f8327 to
6b0ea04
Compare
jeffreyssmith2nd
approved these changes
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #689
API Changes
Documentation Additions