Merge pull request #715 from EOSIO/shouldHash_to_jssignatureProvider

Added false for shouldHash to sign() usages (release/21.0.x branch)
EOSIO · Apr 10, 2020 · edb6be4 · edb6be4
2 parents 14ff1ca + 40800dc
commit edb6be4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/eosjs-jssig.ts b/src/eosjs-jssig.ts
@@ -69,7 +69,7 @@ class JsSignatureProvider implements SignatureProvider {
             const publicKey = PublicKey.fromString(key);
             const ellipticPrivateKey = this.keys.get(convertLegacyPublicKey(key));
             const privateKey = PrivateKey.fromElliptic(ellipticPrivateKey, publicKey.getType());
-            const signature = privateKey.sign(digest);
+            const signature = privateKey.sign(digest, false);
             signatures.push(signature.toString());
         }
 

diff --git a/src/tests/eosjs-jssig.test.ts b/src/tests/eosjs-jssig.test.ts
@@ -126,7 +126,8 @@ describe('JsSignatureProvider', () => {
             expect(
                 signature.verify(
                     digestFromSerializedData(chainId, serializedTransaction),
-                    PublicKey.fromString(k1FormatPublicKeys[0])
+                    PublicKey.fromString(k1FormatPublicKeys[0]),
+                    false
                 )
             ).toEqual(true);
         });
@@ -289,7 +290,8 @@ describe('JsSignatureProvider', () => {
             expect(
                 signature.verify(
                     digestFromSerializedData(chainId, serializedTransaction),
-                    PublicKey.fromString(r1FormatPublicKeys[0])
+                    PublicKey.fromString(r1FormatPublicKeys[0]),
+                    false
                 )
             ).toEqual(true);
         });