Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[1.9.x] Wait for CDT binary. #431

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[1.9.x] Wait for CDT binary. #431

merged 1 commit into from
Jan 17, 2020

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Jan 17, 2020

Change Description

PR #338 introduced logic to wait for the dependent Docker image with EOS installed as listed in pipeline.jsonc to be built and pushed if it does not exist. Build #978 illustrated a need for the same logic to be applied when downloading the dependent CDT binary:

  • Added logic to retry downloading the dependent CDT binary.
  • Improved logging output:
    • Logs show the command being used to download CDT.
    • Logs detail failures when downloading CDT every minute, including a link to the expected build which should have created the artifact.
  • Updated build/test commands to support new logic:
    • The download is retried until it succeeds. The artifact is now mounted into the build/test container, meaning we no longer need to download it at that time.
  • Increased timeout to support extended time of CDT builds.

See:
Build #999 | This exercises the retry functionality when downloading CDT. It waits for an artifact to be produced from this CDT build.
Build #1002 | This PR build.
Build #421 | Travis build.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@arhag arhag merged commit 0bba461 into release/1.9.x Jan 17, 2020
@arhag arhag deleted the cicd-retry-cdt-r1.9 branch January 17, 2020 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants