This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
[develop] Fix build breaking when specifying commit hash #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed issue where specifying a commit for
eosio
oreosio.cdt
inpipeline.jsonc
would result in the build to fail.EOSIO_COMMIT
orCDT_COMMIT
resulting in null strings when checking the GitHub API.grep -v 'null'
. This resulted in an exit code of 1 as no strings exist that do not match null.pipeline.jsonc
as originally intended.See:
Build #602 | Buildkite build where the CDT version is specified by a commit hash.
Build #304 | Travis build where the CDT version is specified by a commit hash.
Deployment Changes
API Changes
Documentation Additions