Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[develop] Fix build breaking when specifying commit hash #334

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Sep 17, 2019

Change Description

Fixed issue where specifying a commit for eosio or eosio.cdt in pipeline.jsonc would result in the build to fail.

  • This was due to the checks for EOSIO_COMMIT or CDT_COMMIT resulting in null strings when checking the GitHub API.
  • We took this value and piped into grep -v 'null'. This resulted in an exit code of 1 as no strings exist that do not match null.
  • This solution now replaces null with empty lines, then removes all empty lines to either get an empty string or the commit HEAD of the branch/tag as determined by GitHub's API. If the string is empty, it means we use the value supplied in pipeline.jsonc as originally intended.

See:
Build #602 | Buildkite build where the CDT version is specified by a commit hash.
Build #304 | Travis build where the CDT version is specified by a commit hash.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@scottarnette scottarnette changed the title Cicd commit fix dev [develop] Fix build breaking when specifying commit hash Sep 17, 2019
@scottarnette scottarnette marked this pull request as ready for review September 17, 2019 18:17
@scottarnette scottarnette merged commit 8300d21 into develop Sep 17, 2019
@scottarnette scottarnette deleted the cicd-commit-fix-dev branch September 17, 2019 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants