Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Fix decoding crashes in decoding for get account and get actions. #213

Merged
merged 3 commits into from
Aug 15, 2019

Conversation

opi-smccoole
Copy link
Contributor

Add EosioInt64 type to handle 64 bit integers that can be numeric or string in RPC JSON responses.

Updated RPC response structures for EosioRpcAccountResponse and EosioRpcActionsResponseActionTrActDeltas to use EosioInt64.

Update tests to exercise new EosioInt64 type.

There may be additional types that will need to be changed from EosioUInt64 to EosioInt64 in the future but these are the ones that are currently known.

…string in RPC JSON responses.

Update tests to exercise new EosioInt64 type.
@opi-smccoole opi-smccoole requested review from a team August 15, 2019 16:40
@opi-smccoole opi-smccoole changed the base branch from master to develop August 15, 2019 17:21
Copy link
Contributor

@brandonfancher brandonfancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@opi-smccoole opi-smccoole merged commit ad7efbd into develop Aug 15, 2019
@opi-smccoole opi-smccoole deleted the rpc-response-negative-values-fix branch August 15, 2019 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants