-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v2.1.2 #383
Merged
Merged
Fix v2.1.2 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified the calculation of the junction location to match what is currently expected from the portcullis file
…s impossible without digging really deeply into how Python deals with pipes and streams, so we will shelve it for now.
…without providing a file format.
… 'pacbio.bam' in the sample_data, fixing the system tests
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 81.58% 85.54% +3.95%
==========================================
Files 106 110 +4
Lines 19314 19318 +4
==========================================
+ Hits 15757 16525 +768
+ Misses 3557 2793 -764 |
…ocus classes. Minor bugfixes after introducing the changes.
…ing in multiprocessing.
…rsing of input list files.
…pare with BAM files.
…programs utilities to create logs
…culated once and retrieved lazily using a LRU cache
… of the code that seem unreachable or anyway never reached.
… Added a batch of tests to make sure that section of the code is properly covered.
…defined in the database
…ered by transcripts persistently having a score below 0. Properly tested now. Also expanded the unit-test suite.
…mble/mikado pipeline in coverage analysis. Added tests for the 'is_intersecting' and 'define_graph' sections of superlocus.
…so, added a test for the junction loading.
…s) for BED12 and ORF loading. CHANGELOG updated.
This was
linked to
issues
Mar 13, 2021
…Mikado util stats to deal with BAM files.
…irectory needed to get set before we executed the functions to create the loggers.
…oading. Now Mikado serialise will immediately stop and exit if there is a mismatch between the TSV queries and/or targets, on one hand, and the query/target FASTA databases, on the other. Refactored the Hit and Hsp classes so that it is easier to create instances, for unit-testing. The old __init__ have now become class methods to create instances from Hit/Hsps objects coming from the BLAST XML parsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #381
Fix #382