Fix #186 and #189 #191
Merged
Fix #186 and #189 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last FAI for the tests.
* #186: introduced a maximum intron length parameter for mikado prepare (prepare/max_intron_length), with a default value of 1M bps and a minimum value of 20. * #186: fixed command lines for configure and prepare. #183: added static seed from CLI for pick. * #186: Fixed previous commit. * Fix environment.yml
…cated ORFs, which potentially led to a lot of them being called incorrectly at the serialisation stage. Refactored the function responsible for the mishap and added a unit-test which confirmed fixing of the bug.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
Coverage ? 83.42%
=========================================
Files ? 106
Lines ? 24759
Branches ? 0
=========================================
Hits ? 20656
Misses ? 4103
Partials ? 0 |
lucventurini
added a commit
to lucventurini/mikado
that referenced
this pull request
Feb 11, 2021
…ioinformatics#191) * Fix EI-CoreBioinformatics#189 * Fix EI-CoreBioinformatics#186 * EI-CoreBioinformatics#183: added static seed from CLI for pick. * EI-CoreBioinformatics#186: introduced a maximum intron length parameter for mikado prepare (prepare/max_intron_length), with a default value of 1M bps and a minimum value of 20. * EI-CoreBioinformatics#186: there was a very serious bug in the evaluation of negative truncated ORFs, which potentially led to a lot of them being called incorrectly at the serialisation stage. Refactored the function responsible for the mishap and added a unit-test which confirmed fixing of the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.