Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloading __getattribute__ in Transcript causes a massive slowdown #154

Closed
lucventurini opened this issue Mar 13, 2019 · 1 comment
Closed

Overloading __getattribute__ in Transcript causes a massive slowdown #154

lucventurini opened this issue Mar 13, 2019 · 1 comment
Assignees
@lucventurini
Labels
enhancement
Milestone
2.0

Comments

@lucventurini
Copy link
Collaborator

After testing, I realised that overloading the getattribute method causes a massive slowdown in basically the whole program. This is because the Transcript class is practically ever-present, and overloading the base method causes a massive slowdown in everything, from the comparison, to the statistics, to any core functionality. I am now testing whether removing the overloading causes problems with the external attributes (the original problem for which the overloading was introduced) and if so, what are the possible solutions.
@lucventurini lucventurini self-assigned this Mar 13, 2019
@lucventurini lucventurini added this to the 1.5 milestone Mar 13, 2019
lucventurini added a commit that referenced this issue Mar 13, 2019
@lucventurini
Potential fix for #154 - but we need to verify for external metrics; …
c46af7b 
…now Mikado compare can be used with parallelism
lucventurini added a commit that referenced this issue Mar 22, 2019
@lucventurini
This commit should fix the problem of retrieving attributes such as e…
90663c1 
…xternal.score (#154) from Transcript objects WITHOUT slowing down the whole application.
lucventurini added a commit that referenced this issue Mar 22, 2019
@lucventurini
Small tentative fix for #154
1e9f883
lucventurini added a commit that referenced this issue Mar 22, 2019
@lucventurini
Final small fix for #154
09b887c
@lucventurini
Copy link
Collaborator Author

Fixed, tested by @gemygk. Closing.

lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Potential fix for EI-CoreBioinformatics#154 - but we need to verify f…
5e07b07 
…or external metrics; now Mikado compare can be used with parallelism
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
This commit should fix the problem of retrieving attributes such as e…
ac50150 
…xternal.score (EI-CoreBioinformatics#154) from Transcript objects WITHOUT slowing down the whole application.
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Small tentative fix for EI-CoreBioinformatics#154
2a62165
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Final small fix for EI-CoreBioinformatics#154
00d4bd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucventurini lucventurini

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@lucventurini