Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directed selection for mikado prepare #141

Closed
lucventurini opened this issue Nov 5, 2018 · 3 comments
Closed

Directed selection for mikado prepare #141

lucventurini opened this issue Nov 5, 2018 · 3 comments
Assignees
Milestone

Comments

@lucventurini
Copy link
Collaborator

Currently, in Mikado prepare, we perform two checks that might end up discarding transcripts:

1- a redundancy check, which will throw away multiple copies of transcripts regardless of their origin
2- a requirements check, which will throw away transcripts if they fail some basic checks.

Both steps are good and necessary, however, they need to be tweaked as follows:

1- during the redundancy check, transcripts should be prioritised according to their source score (if present). If a transcript source has been marked as "reference", those transcripts should always be kept.
2- During the requirements check, transcripts that have been marked as "reference" should always be kept.

@lucventurini
Copy link
Collaborator Author

Additionally, we should also make configure scoop up the status of a given assembly when loading from a sample sheet. Currently the functionality is implemented but not tested.

@lucventurini
Copy link
Collaborator Author

"Reference" transcripts will be treated as follows during the prepare step:

  • A transcript which is marked as “reference” will never have its CDS stripped
  • A transcript which is marked as “reference” will never be marked for removal due to redundancy, even if there are multiple copies of it, or if other assemblies with a higher score have identical transcripts (normally only one transcript would be retained, and that would be chosen amongst the highest scoring assemblies)
  • A transcript which is marked as reference will never have its strand removed or flipped.

@lucventurini
Copy link
Collaborator Author

lucventurini commented Jan 25, 2019

This issue is now putatively solved, although tests for it need to be implemented properly.
Shifting it to #137

lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
… on the basis of their source score. Properly tested, as per EI-CoreBioinformatics#137, and documentation updated, as per EI-CoreBioinformatics#136.
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
…oinformatics#141 and tests them properly (EI-CoreBioinformatics#137). We should still create tests for the mikado configure step, and update the documentation (EI-CoreBioinformatics#136).
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
…nformatics#137) - including the daijin test, solved some minor bugs present in earlier commits, indicated the EICore repo as the main in the docs, now EI-CoreBioinformatics#141 should be ready to be closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants