-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directed selection for mikado prepare #141
Comments
Additionally, we should also make configure scoop up the status of a given assembly when loading from a sample sheet. Currently the functionality is implemented but not tested. |
"Reference" transcripts will be treated as follows during the prepare step:
|
This issue is now putatively solved, although tests for it need to be implemented properly. |
lucventurini
added a commit
to lucventurini/mikado
that referenced
this issue
Feb 11, 2021
… on the basis of their source score. Properly tested, as per EI-CoreBioinformatics#137, and documentation updated, as per EI-CoreBioinformatics#136.
lucventurini
added a commit
to lucventurini/mikado
that referenced
this issue
Feb 11, 2021
…oinformatics#141 and tests them properly (EI-CoreBioinformatics#137). We should still create tests for the mikado configure step, and update the documentation (EI-CoreBioinformatics#136).
lucventurini
added a commit
to lucventurini/mikado
that referenced
this issue
Feb 11, 2021
…nformatics#137) - including the daijin test, solved some minor bugs present in earlier commits, indicated the EICore repo as the main in the docs, now EI-CoreBioinformatics#141 should be ready to be closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, in Mikado prepare, we perform two checks that might end up discarding transcripts:
1- a redundancy check, which will throw away multiple copies of transcripts regardless of their origin
2- a requirements check, which will throw away transcripts if they fail some basic checks.
Both steps are good and necessary, however, they need to be tweaked as follows:
1- during the redundancy check, transcripts should be prioritised according to their source score (if present). If a transcript source has been marked as "reference", those transcripts should always be kept.
2- During the requirements check, transcripts that have been marked as "reference" should always be kept.
The text was updated successfully, but these errors were encountered: