Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During picking, the original phases are lost #138

Closed
lucventurini opened this issue Oct 18, 2018 · 1 comment
Closed

During picking, the original phases are lost #138

lucventurini opened this issue Oct 18, 2018 · 1 comment
Assignees
@gemygk @lucventurini
Labels
bug
Milestone
2.0

Comments

@lucventurini
Copy link
Collaborator

This prevents picking from correctly evaluating transcripts with truncated ORFs and must be solved with the utmost urgency.
@lucventurini lucventurini added this to the 1.3 milestone Oct 18, 2018
lucventurini added a commit that referenced this issue Oct 18, 2018
@lucventurini
Fixes for #137 and #138
b84f626
@lucventurini
Copy link
Collaborator Author

Solved. This required modifying the "as_dict" and "load_dict" methods for Transcript, plus an internal method during the Transcript finalization.

As a bonus, solving this bug means that now Mikado can successfully finalize transcripts with multiple internal ORFs (before, they had to be without an ORF and ORFs had to be loaded separately).

lucventurini added a commit that referenced this issue Oct 26, 2018
@lucventurini
Mikado now can accept numerical values such as TPM for the serialisat…
9199381 
…ion. Updated tests (#137) and documentation (#138)
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Fixes for EI-CoreBioinformatics#137 and EI-CoreBioinformatics#138
6d35778
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Mikado now can accept numerical values such as TPM for the serialisat…
392e2af 
…ion. Updated tests (EI-CoreBioinformatics#137) and documentation (EI-CoreBioinformatics#138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gemygk gemygk

@lucventurini lucventurini

Labels
bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@gemygk @lucventurini