Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDS not stripped from transcripts when model is reversed #126

Closed
lucventurini opened this issue Sep 26, 2018 · 2 comments
Closed

CDS not stripped from transcripts when model is reversed #126

lucventurini opened this issue Sep 26, 2018 · 2 comments
Assignees
@lucventurini
Labels
bug
Milestone
2.0

Comments

@lucventurini
Copy link
Collaborator

As noted by @gemygk and communicated to @swarbred, Mikado models with a CDS that get reversed do not get their CDS stripped. This is of course a mistake that has to be corrected.
@lucventurini lucventurini self-assigned this Sep 26, 2018
lucventurini added a commit that referenced this issue Sep 26, 2018
@lucventurini
Solving #126, also adding unit tests
fdc54e3
@lucventurini
Copy link
Collaborator Author

As an additional requirement, if "strip_cds" is False and the CDS would be stripped, Mikado should raise an InvalidTranscript error.

lucventurini added a commit that referenced this issue Sep 26, 2018
@lucventurini
Ulterior fixes for #126. Now a monoexonic model is always kept on its…
e59ce90 
… strand if it is coding, while a multiexonic model is completely refused if it is coding and it should have its strand swapped.
@lucventurini lucventurini added this to the 1.3 milestone Oct 5, 2018
@lucventurini
Copy link
Collaborator Author

This should also have its tests done. Closing.

lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Solving EI-CoreBioinformatics#126, also adding unit tests
cc5f8e6
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Ulterior fixes for EI-CoreBioinformatics#126. Now a monoexonic model …
c32ee8d 
…is always kept on its strand if it is coding, while a multiexonic model is completely refused if it is coding and it should have its strand swapped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucventurini lucventurini

Labels
bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@lucventurini