Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Refactor and enhance trivialize-cookie-rules.js #17438

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Refactor and enhance trivialize-cookie-rules.js #17438

merged 3 commits into from
Mar 11, 2019

Conversation

cschanaj
Copy link
Collaborator

No description provided.

Refactor and enhance trivialize-cookie-rules.js
3c76715 
With help from @pipboy96 on some syntax issues, re-open #17420
@cschanaj cschanaj mentioned this pull request Feb 12, 2019
Closed
@cschanaj
Copy link
Collaborator Author

cschanaj commented Feb 21, 2019 •
edited
Loading

cc @Hainish @zoracon The modified script will trivialize the securecookie tags of additional 120+ rulesets, hope this can be merged before the next ruleset release. thanks.

@zoracon zoracon added this to the Before the Next Release milestone Feb 22, 2019
@zoracon zoracon self-requested a review February 22, 2019 01:01
@cschanaj
Copy link
Collaborator Author

cschanaj commented Mar 9, 2019

@zoracon would you review and merge this when you have the time? I would to like run this script in another PR and preferably includes the changes from this and #17492 in the next ruleset release.

cc @Hainish

This was referenced Mar 9, 2019
Closed
Merged
@zoracon zoracon merged commit 2a7a7e8 into EFForg:master Mar 11, 2019
@cschanaj cschanaj deleted the trivialize-cookie-rules-js-1 branch March 11, 2019 22:23
This was referenced Mar 11, 2019
Closed
Merged
@zoracon zoracon mentioned this pull request Apr 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zoracon zoracon zoracon approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Before the Next Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cschanaj @zoracon