Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Create ruleset: JSON Schema #17067

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Conversation

FranklinYu
Copy link
Contributor

I searched site:*.json-schema.org but didn't find any subdomain.

@FranklinYu
Copy link
Contributor Author

I believe that the failure is irrelevant. Please advise whether I should trigger a re-run.

@Bisaloo
Copy link
Collaborator

Bisaloo commented Nov 15, 2018

Thank you for your PR! Here are a small list of changes before I can merge. Can you please:

  • add a rule to redirect http://www.json-schema.org to https://json-schema.org. With a top comment explaning that www.json-schema.org certificat is invalid.
  • change the filename to JSON-Schema.org.xml. That way, we know the domain without opening the file.
  • update the ruleset name to JSON-Schema.org to match the filename.

@Bisaloo Bisaloo self-assigned this Nov 15, 2018
@Bisaloo Bisaloo merged commit bf07f56 into EFForg:master Nov 15, 2018
@Bisaloo Bisaloo removed their assignment Nov 15, 2018
@FranklinYu FranklinYu deleted the rules/json-schema branch November 20, 2018 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants