Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReFrame generated topology for hortense cpu partitions #195

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented Oct 17, 2024

The tests of PyCharm currently fail because of missing information of the processor. So using reframe --detect-host-topology is a better way forward until sched_options becomes part of the ReFrame release.

@boegel
Copy link
Contributor

boegel commented Oct 17, 2024

@laraPPr lgtm, but code style check fails:

./config/vsc_hortense.py:7:121: E501 line too long (131 > 120 characters)
./config/vsc_hortense.py:19:121: E501 line too long (125 > 120 characters)

vsc46128 vscuser and others added 2 commits October 18, 2024 10:13
Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine (with some suggestions for the comments), but shouldn't you also remove the processor info from the gpu partitions?

config/vsc_hortense.py Outdated Show resolved Hide resolved
config/vsc_hortense.py Outdated Show resolved Hide resolved
config/vsc_hortense.py Show resolved Hide resolved
laraPPr and others added 3 commits November 9, 2024 15:27
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
@laraPPr
Copy link
Collaborator Author

laraPPr commented Nov 27, 2024

works fine (with some suggestions for the comments), but shouldn't you also remove the processor info from the gpu partitions?

I wanted to look deeper into what reframe was detecting on a machine with GPUs before doing this. I had the chance to do that so I'll remove the processor info also for those ones.

Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 66b678d into EESSI:main Nov 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants