-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReFrame generated topology for hortense cpu partitions #195
Conversation
@laraPPr lgtm, but code style check fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine (with some suggestions for the comments), but shouldn't you also remove the processor info from the gpu partitions?
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
I wanted to look deeper into what reframe was detecting on a machine with GPUs before doing this. I had the chance to do that so I'll remove the processor info also for those ones. |
…uite into fix_hortense_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The tests of PyCharm currently fail because of missing information of the processor. So using
reframe --detect-host-topology
is a better way forward untilsched_options
becomes part of the ReFrame release.