Skip to content

Commit

Permalink
fix setting ci with bench_name check
Browse files Browse the repository at this point in the history
  • Loading branch information
Samuel Moors committed Dec 12, 2024
1 parent 0568d1e commit a38870a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions eessi/testsuite/eessi_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class EESSI_Mixin(RegressionMixin):
# Set defaults for these class variables, can be overwritten by child class if desired
measure_memory_usage = variable(bool, value=False)
scale = parameter(SCALES.keys())
bench_name = None
bench_name_ci = None

# Create ReFrame variables for logging runtime environment information
Expand All @@ -63,8 +64,6 @@ def __init_subclass__(cls, **kwargs):
cls.valid_systems = ['*']
if not cls.time_limit:
cls.time_limit = '1h'
if 'bench_name' not in dir():
cls.bench_name = None

# Helper function to validate if an attribute is present it item_dict.
# If not, print it's current name, value, and the valid_values
Expand Down
4 changes: 1 addition & 3 deletions eessi/testsuite/tests/apps/QuantumESPRESSO.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ class EESSI_QuantumESPRESSO_PW(QEspressoPWCheck, EESSI_Mixin):
module_name = parameter(find_modules('QuantumESPRESSO'))
# For now, QE is built for CPU targets only
device_type = parameter([DEVICE_TYPES[CPU]])
bench_name_ci = 'bench_ci'
bench_name = None

def required_mem_per_node(self):
return (self.num_tasks_per_node * 0.9 + 4) * 1024
Expand All @@ -55,7 +53,7 @@ def set_ci(self):
min_ecut = min(QEspressoPWCheck.ecut.values)
min_nbnd = min(QEspressoPWCheck.nbnd.values)
if self.ecut == min_ecut and self.nbnd == min_nbnd:
self.bench_name = self.bench_name_ci
self.bench_name = self.bench_name_ci = 'bench_ci'

@run_after('init')
def set_increased_walltime(self):
Expand Down

0 comments on commit a38870a

Please sign in to comment.