Bug fixes in patch/cohort fusion #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y small non-zero LAIs were problematic.
…ort fusion, this was causing errors.
mdietze
added a commit
that referenced
this pull request
Aug 27, 2014
Bug fixes in patch/cohort fusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1 was creating infiniti's when dividing by extremely low patch areas, fixed.
Bug 2 was enabling fusion mean diagnostic variables during patch fusion when it was not appropriate (i.e. when those variables were not non-zero. In some cases we used simple thermodynamics to update various quantities and was creating model crashes.