default テンプレートをレスポンシブWebデザイン対応する #1065 #1125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bluestylejp-toya 氏提供のテンプレートを取り込み。 - data/class/SC_Display.php data/Smarty/templates/admin/design/subnavi.tpl の対応に関しては、議論が必要と認識している。 - #804 適用前でブランチを切った。master マージに辺り、#804 の再適用が必要。
ついでに、Media Queries Level 4 を使う。
必要なものは、復元して、ソースコメント書いてください。
テンプレートをPC・スマートフォンで別々に設定できる仕組みと互換性がない変更を差し戻す。 git restore --source=88f072123af8464ba0181f4ddfa29bf75846d198 data/class/SC_Display.php data/Smarty/templates/admin/design/subnavi.tpl
PC・スマートフォンで同一テンプレートを設定すると、スマートフォンでもPCのレイアウト情報を読み込む。
MySQL 漏れ修正
テストを調整する。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
=======================================
Coverage 50.05% 50.06%
=======================================
Files 82 82
Lines 10580 10582 +2
=======================================
+ Hits 5296 5298 +2
Misses 5284 5284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add SC_Helper_PageLayoutTest
|
enhancement 対応となりますので、以下マイルストーンのリリース完了後に取り込みさせていただきますね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1065
fixed #1128