FileManager：display filePath when you upload a file. #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy favicon to user_data directory
|
@YuYu777 |
backup of user_data to tmp dirs
chihiro-adachi
suggested changes
Feb 12, 2019
|
|
||
| $('.action-copy').on('click',function(){ | ||
| updated = $(this).parents('tr').find('.updated'); | ||
| copy_file_path = $(this).parents('tr').find('.copy-file-path'); |
chihiro-adachi
approved these changes
Feb 12, 2019
chihiro-adachi
added
Status: ready-for-merge
affected:admin_template
nanasess
added a commit
to nanasess/ec-cube
that referenced
this pull request
Feb 13, 2019
FileManager：display filePath when you upload a file.
nanasess
added a commit
to nanasess/ec-cube
that referenced
this pull request
Feb 13, 2019
FileManager：display filePath when you upload a file.
|
messages.en.yaml にも追加が必要ですね |
Add messages to messages.en.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
ファイル管理にてアップロードしたファイルパスの表示 ファイル管理にてアップロードしたファイルパスの表示 #4072
方針(Policy)
ファイルパス取得時、「//」となってしまうのでTwig側で「/」を削除しています。
実装に関する補足(Appendix)
faviconのPRをマージしています。
テスト（Test)
E2Eテスト作成・実行しています。
相談（Discussion）
Windows環境で作ってます。
マイナーバージョン互換性保持のための制限事項チェックリスト