-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MkDocs documentation for ReadTheDocs #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. There's two minor things I stumbled upen when looking through the docs. I commented on the relevant files.
Some of the doscstrings will need a bit of TLC (e.g. ,SECFingerprintTransformer) but I guess it gets easier to spot and correct once we get this doc system up and running, so that can come over time.
Just a question: After things are set up, the docs will be live on mkdocs? then _doc_link_template and _doc_link_url can be implemented on the classes.
Yeah, it will be much more convenient to work on docstrings once the docs deployment is enabled. The docs will be live on ReadTheDocs - I already tested deployment on my fork and it works fine. So after the PR will be merged what is left is to import project to RTD. It is simple and mostly automatic process. |
Sounds great. You are welcome to put it live on RTD, sound like you already know what to do. But, can I also get administrator rights to the deployment there? |
This pull request includes several updates to the documentation, configuration files, and contribution guidelines. The most important changes include adding a new Read the Docs configuration file, updating the
CONTRIBUTING.md
file with new instructions, and modifying the.pre-commit-config.yaml
file to exclude.ipynb
files from certain checks.Documentation Updates:
Documentation should be good to go, docstring can still be improved, but this is good starting point.
Last step is to deploy the docs will be to activate RTD build, once PR is merged
.readthedocs.yaml
) to set up the documentation build environment and process.Configuration Updates:
.pre-commit-config.yaml
to exclude.ipynb
files from thepretty-format-json
check.Code Ownership:
.github/CODEOWNERS
to assign specific files to their respective owners.Build and Testing:
Makefile
targets for syncing and running notebooks.These changes aim to improve the documentation process, streamline the contribution workflow, and ensure proper code ownership and formatting.