GA4GHTT-276: 4.4 changes - optional meta, format CN, CICN, PSL, PSO, PSQ #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
Aug 23, 2024
| * @param ret return by reference the container filled with the string split. | ||
| */ | ||
| template<typename C> | ||
| void string_split_ex(std::string const & s, char const * delims, C & ret, bool withdelim) |
There was a problem hiding this comment.
Is there any need to keep both implementation ?
If you don't want to replace all calls to the extended version I would at least use string_split_ex in string_split
There was a problem hiding this comment.
It was retained to avoid any impact.
Updated to use _ex with no delimiter and tests succeeded without any failure.
Updated PR with the change.
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
tcezard
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining changes for vcf4.4
Type P, format tags PSL, PSO, PSQ, CN type update and CICN addition.
PSO validation is to match the count to PSL fields. No check on cached records made as it might not be efficient.
Description made optional for ALT and FILTER meta data.
Format CICN validated with presence of format CN and warning generated on CICN value when it doesn't span across 0.
Check on SVLEN with CN moved from optional/warning to mandatory/error (SV to have same SVLEN when format CN is present).